-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ios): drop xcode 8 support #11343
Conversation
|
Pretty important to note that this also bumps minimum iOS from 9 to 10. |
@sgtcoolguy, I thought the |
Ok, so we have two separate "minimums" in the package.json. The one bumped here (in The other Maybe @cb1kenobi has a better handle on the difference between the two (or why we have 2 values that more or less seem to denote min iOS sdk versions)? |
Just confirming that this PR works fine building to an iOS 9 device, I think the transpile target should be updated to use this.minIosVersion which correctly calculates the minimum iOS version for an app based off |
Yes. This will not change minimum iOS target. cc @cb1kenobi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iOS changes are looking good, approved!
BTW, i noticed it too that we use the wrong value for the preset-env option while working on the Webpack tooling. The appcd plugin already uses the correct value:
// EDIT: I created https://jira.appcelerator.org/browse/TIMOB-27630 for the update in the SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as the babel setup fix was split out to TIMOB-27630, this PR looks good to me
FR Passed. |
https://jira.appcelerator.org/browse/TIMOB-27497