-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS)(8_2_X): can not show fullscreen modal windows anymore #11268
Conversation
|
UIModalPresentationStyle style = [(id<TiWindowProtocol>)_proxy adaptivePresentationStyleForPresentationController:controller]; | ||
return style; | ||
} | ||
return UIModalPresentationNone; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default should be UIModalPresentationAutomatic
for iOS 13+ and UIModalPresentationNone
for < iOS 13 as per documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per Hans' comment, change the return value based on the iOS version. The rest looks good to me.
Updated! |
Found an issue with the latest build for this PR. On iOS device with version < 13 the style FORMSHEET shows up as FULLSCREEN. The difference is visible in landscape. |
FR Passed. Modal windows shown properly as per the style. |
https://jira.appcelerator.org/browse/TIMOB-27453
Need to merge PR #11257 first.