-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(conditions): Change from ifdef to if due to variable always being defined #11255
Conversation
… defined The test for whether or not we're using iOS 13 was using an ifdef condition, but this is always defined as either true or false in the Titanium_Prefix.pch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
QE: Please just mark as FR passed or not and tag me and I will squash merge this once it's ready (and cherry-pick to master) |
FR Passed. |
@sgtcoolguy Kindly merge the PR and cherry-pick to master |
|
The test for whether or not we're using iOS 13 was using an ifdef condition, but this is always
defined as either true or false in the Titanium_Prefix.pch
https://jira.appcelerator.org/browse/TIMOB-27435