-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): added xcworkspacedata file generation #11245
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI code looks ok to me, I'm able to rebuild with the app open just fine and don't get a full rebuild.
I'm going to ask @appcelerator/ios to take a check of the SDK code though.
Just wanted to also note that we now get some extraneous logging in comparison to 8.2.0.GA
Before:
-- Start simulator log -------------------------------------------------------
[DEBUG] Reading stylesheet from: /Users/awam/Library/Developer/CoreSimulator/Devices/99124622-6287-4600-B62A-FE053C8B8B5E/data/Containers/Bundle/Application/1E45668E-CA30-48B2-8DE8-CBF4BD3ABEF2/ticreateapp.app/stylesheet.plist
[INFO] ticreateapp 1.0 (Powered by Titanium 8.2.0.6bfdf6e394)
[DEBUG] Firing app event: started
[INFO] load
With this PR:
-- Start simulator log -------------------------------------------------------
[DEBUG] Reading stylesheet from: /Users/awam/Library/Developer/CoreSimulator/Devices/99124622-6287-4600-B62A-FE053C8B8B5E/data/Containers/Bundle/Application/639726C4-D6B6-46BE-8D05-67716B56645B/ticreateapp.app/stylesheet.plist
[DEBUG] You've implemented -[<UIApplicationDelegate> application:performFetchWithCompletionHandler:], but you still need to add "fetch" to the list of your supported UIBackgroundModes in your Info.plist.
[DEBUG] You've implemented -[<UIApplicationDelegate> application:didReceiveRemoteNotification:fetchCompletionHandler:], but you still need to add "remote-notification" to the list of your supported UIBackgroundModes in your Info.plist.
[TRACE] [ticreateapp] assertion failed: 18G95 17A577a: libxpc.dylib + 83495 [9A486F3D-BBFA-36F2-9105-42A059A13A8A]: 0x7d
[DEBUG] APSAnalytics: Initialization started...
[INFO] APSAnalyticsStore: session.start
[INFO] ticreateapp 1.0 (Powered by Titanium 8.2.1.ad9ad91a4a)
[INFO] Reachability Flag Status: -R ------- networkStatusForFlags
[DEBUG] Firing app event: started
[INFO] Application started
[INFO] load
[DEBUG] APSAnalytics: Attempting to send 1 analytics event(s)
[INFO] APSAnalytics: Successfully sent 1 stored event(s)
FR Passed. Logs show up for concurrent builds. Studio Ver: 5.1.4.201909061933 |
Waiting for the review for the extra log mentioned above by @ewanharris . |
JIRA: https://jira.appcelerator.org/browse/TIMOB-27331