Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): use correct blob for toImage() #11241

Merged
merged 4 commits into from
Nov 27, 2019

Conversation

garymathews
Copy link
Contributor

  • Override handleToImage to return correct Blob
TEST CASE
const Map = require('ti.map');

const win = Ti.UI.createWindow({ backgroundColor: 'white' });

const img = Ti.UI.createImageView({
    width: 28,
    height: 28,
    image: 'appicon.png'
});

const map = Map.createView({
    region: { latitude: -33.87365, longitude: 151.20689, latitudeDelta: 0.1, longitudeDelta: 0.1 },
    annotations: [
        Map.createAnnotation({
            latitude: -33.87365, 
            longitude: 151.20689,
            title: 'Icon',
            image: img.toImage()
        })
    ],
});

win.add(map);
win.open();
  • Should see icon at center of map

JIRA Ticket

@build build requested a review from a team September 25, 2019 20:16
@build
Copy link
Contributor

build commented Sep 25, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6623 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against 5c09034

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy
Copy link
Contributor

@garymathews Any reason this shouldn't go into 8.3.0?

@ssjsamir ssjsamir self-requested a review November 27, 2019 11:52
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to see an icon in the middle of the app using the code mentioned above.

Test Environment

MacOS Catalina 10.15.1 beta
Xcode 11
Node.js 10.16.3
iphone 8 13.2
"NPM":"4.2.15-1","CLI":"7.1.2-7"
Pixel XL (10.0)

@ssjsamir ssjsamir merged commit f07e012 into tidev:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants