Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): properly set tint-color on image-view #11233

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway added this to the 8.2.1 milestone Sep 20, 2019
@build build requested a review from a team September 20, 2019 21:35
@build
Copy link
Contributor

build commented Sep 20, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 4336 tests are passing.
(There are 471 tests skipped)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against c6cc793

@ssekhri
Copy link

ssekhri commented Sep 24, 2019

FR Passed. Tint color applied successfully to remote images.
Verified on:
Mac OS 10.14.6
Ti SDK: 8.2.1.v20190920141925
Appc CLI: 7.1.1
Node: 10.5.0
JDK: 10.0.2
XCode: 11.0
Studio: 5.1.4.201909061933
Device: iPhone X(v13.0)

@ssekhri ssekhri merged commit 1a47522 into tidev:8_2_X Sep 24, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Sep 25, 2019
* 8_2_X:
  fix(ios): properly set tint-color on image-view (tidev#11233)
  fix(ios)(8_2_X): sf symbol handling for application shortcut (tidev#11222)
  fix(ios): volume event handling (tidev#11227)
  fix(ios): also lookup semnantic colors in correct location for classic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants