-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): exclude JS in HTML files from processing #11214
Conversation
Dependencies with modified semantic versioning:
New dependencies added: nodeifyAuthor: ForbesLindesay Description: Convert promised code to use node style callbacks Homepage: https://github.com/then/nodeify#readme
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR'd and FR'd. Looks good. APPROVED
FR passed. JS files are included when building. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-27398
Optional Description:
Prevent processing of JS files that are referenced in HTML during incremental builds and make sure that those JS file will not be removed by the automatic builder resource cleanup.
This is an Android only issue due to the way the
jsFiles
list is handled in the builder. The iOS builder actually removes entries from JS files that are used in HTML so the issue only occurred on Android. Switching to the pre-filteredinputFiles
of the task solved the issue.The update of
appcd-tasks
is for better error handling since it didn't properly pass the original error in some cases. This made it harder to debug this issue in the first place. With the update the a task failure will now pass down the original error.