-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): fix onlink callback being cretion only #11177
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
(cherry picked from commit 1f51e13)
5bb0f5b
to
7ce9d6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a simple unit test here to create a web view and set the onlink property after creation and verify it ends up getting called.
I just realized that this requires interactive UI to click the link in the webview, so I suppose my review request to add a unit test for this makes no sense.
This is in regards to unit testing. I remember looking into this about 8 years ago. On Android, the native listener only works for physical taps on links. That listener won't be invoked when attempting to navigate via JavaScript, such as by setting the I believe our Appium test suite can simulate physical touches. Perhaps this is the way to go for automated testing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Able to see the "onlink" callback being invoked. Tested with the test case above.
Test Environment
MacOS Catalina 10.15 Beta
Node.js ^8.11.1
Android Pixel XL 7.1 Emulator
"NPM":"4.2.15","CLI":"7.1.1"
(cherry picked from commit 1f51e13)
JIRA: https://jira.appcelerator.org/browse/TIMOB-27238
Description:
Fix
onlink
callback property being creation-only.Test case: