-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(android)(8_3_X): ProgressIndicator dialog handling #11143
Conversation
- [TIMOB-27104] ProgressIndicator logs "WindowLeaked" exception when hiding dialog and closing window at same time as of 8.0.2 - [TIMOB-27308] Determinant ProgressIndicator ignores "value" property before shown - [TIMOB-27309] Cannot re-show ProgressIndicator dialog if auto-closed by previous window - Removed dialog's handleMessage() related code. No longer needed since JS runs on main UI thread.
* Please see the LICENSE included with this distribution for details. | ||
*/ | ||
/* eslint-env mocha */ | ||
/* global Titanium */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 tests/Resources/ti.ui.android.progressindicator.addontest.js line 8 – 'Titanium' is already defined as a built-in global variable. (no-redeclare)
⚠️ tests/Resources/ti.ui.android.progressindicator.addontest.js line 8 – 'Titanium' is defined but never used. (no-unused-vars)
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
FR Passed. The progress indicator works as expected. |
JIRA:
Cherry-pick of PR: #11115