docs(typescript): update sdk version in typescript definition header #10822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Validating locally using the linting in DefinitelyTyped throws some errors, will fix those in this PR |
ewanharris
force-pushed
the
update_typescript_version
branch
from
47c2f32
to
ff972da
Compare
|
@ewanharris Are the changes to the .yml files requires to pass linting or why are they in this PR? |
|
@janvennemann, yes they are required to pass the linting step in DefinitelyTyped. It was throwing the following errors
|
ewanharris
force-pushed
the
update_typescript_version
branch
from
1f33b74
to
26963a2
Compare
ewanharris
force-pushed
the
update_typescript_version
branch
from
26963a2
to
5784903
Compare
janvennemann
approved these changes
May 2, 2019
ewanharris
force-pushed
the
update_typescript_version
branch
from
3577791
to
113df0e
Compare
Correct a couple of invalid docs, remove double newline from end of file
Done by DefinitelyTyped maintainer in DefinitelyTyped/DefinitelyTyped@608c146#diff-948841420dd57be7be5d9d21fe002f4c so we should keep this
ewanharris
force-pushed
the
update_typescript_version
branch
from
113df0e
to
cf6dadc
Compare
sgtcoolguy
pushed a commit
that referenced
this pull request
Jun 6, 2019
…10822) * docs(typescript): update sdk version in typescript definition header * ensure generated typescript def file passing linting * docs(typescript): mark as non-npm package Done by DefinitelyTyped maintainer in DefinitelyTyped/DefinitelyTyped@608c146#diff-948841420dd57be7be5d9d21fe002f4c so we should keep this
hansemannn
pushed a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Jul 8, 2019
…idev#10822) * docs(typescript): update sdk version in typescript definition header * ensure generated typescript def file passing linting * docs(typescript): mark as non-npm package Done by DefinitelyTyped maintainer in DefinitelyTyped/DefinitelyTyped@608c146#diff-948841420dd57be7be5d9d21fe002f4c so we should keep this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether this is what you had in mind but it looks like the docgen script only reads in the version for generating changes, figured it made sense to just require in the package.json in the write header func.