Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): cookie support for ios while using wkwebview (8_0_X) #10786

Merged
merged 6 commits into from
Apr 8, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build
Copy link
Contributor

build commented Mar 20, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 2 tests have failed There are 2 tests failing and 450 skipped out of 3023 total tests.

Tests:

Classname Name Time Error
android.emulator.Titanium.UI.WebView .zoomLevel 10.047 timeout of 10000ms exceeded
ios.Titanium.Media.AudioPlayer #start, #stop 3.086 timeout of 2000ms exceeded

Generated by 🚫 dangerJS against 7a73d6a

@janvennemann janvennemann changed the title fix(ios): cookie support for ios while using wkwebview fix(ios): cookie support for ios while using wkwebview (8_0_X) Mar 20, 2019
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed Using the the following test case:

var win = Ti.UI.createWindow({

layout : 'vertical'
});
 
var testUrl = "https://jwogan5.github.io/";
var testDomain = "jwogan5.github.io";
 
Titanium.Network.addHTTPCookie(Titanium.Network.createCookie({
domain : testDomain,
name : 'testCookie',
path : '/',
value : 'works'
}));
var testWebView = Ti.UI.createWebView({
url : testUrl,
width : Ti.UI.FILL,
top : 0,
cacheMode : false,
enableZoomControls : false,
bottom : 0
});
win.add(testWebView);
win.open();

Test Environment

iPhone 6S plus (12.1 Sim)
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed. Triggered a Jenkins rebuild to pass CI check.

@sgtcoolguy
Copy link
Contributor

ok, so the failing tests are unrelated and appear to be intermittent failures. I'm going to merge this one in.

@sgtcoolguy sgtcoolguy merged commit ded78d1 into tidev:8_0_X Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants