-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): cookie support for ios while using wkwebview (8_0_X) #10786
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed Using the the following test case:
var win = Ti.UI.createWindow({
layout : 'vertical'
});
var testUrl = "https://jwogan5.github.io/";
var testDomain = "jwogan5.github.io";
Titanium.Network.addHTTPCookie(Titanium.Network.createCookie({
domain : testDomain,
name : 'testCookie',
path : '/',
value : 'works'
}));
var testWebView = Ti.UI.createWebView({
url : testUrl,
width : Ti.UI.FILL,
top : 0,
cacheMode : false,
enableZoomControls : false,
bottom : 0
});
win.add(testWebView);
win.open();
Test Environment
iPhone 6S plus (12.1 Sim)
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed. Triggered a Jenkins rebuild to pass CI check.
ok, so the failing tests are unrelated and appear to be intermittent failures. I'm going to merge this one in. |
https://jira.appcelerator.org/browse/TIMOB-26903