Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26113] iOS: Prioritize ti.ui.defaultunit over other dimensions #10101

Closed
wants to merge 4 commits into from

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-26113

Adding tests once CR approved

@build
Copy link
Contributor

build commented Jun 12, 2018

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

🚫

Tests have failed, see below for more information.

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
ios.Titanium.UI #convertUnits() returns 0 if percentage used 0.001 file:///Users/build/Library/Develope
ios.Titanium.UI #convertUnits() returns dpi pixels = 25.4 mm 0.001 file:///Users/build/Library/Developer/CoreSimulator/Device
ios.Titanium.UI #convertUnits() converts dpi pixels = 1 in 0 file:///Users/build/
ios.Titanium.UI #convertUnits() returns Ti.Platform.DisplayCaps.logicalDensityFactory pixels = 1 dip 0 file:///Users/build/Library/Developer/
ios.Titanium.UI #convertUnits() returns dpi pixels = 2.54 cm 0 file:///Users/build/Library/Developer/CoreSimulator/Device
ios.Titanium.UI #convertUnits() returns 25.4 mm = dpi pixels 0 file:///Users/build/Library/Developer/CoreSimulator/Devic
ios.Titanium.UI #convertUnits() returns 1mm = 0.0393701in 0 file:///Users/build/Library/Developer/CoreSimulator/Devices/6D5153E
ios.Titanium.UI #convertUnits() returns 25.4 mm = (dpi / logicalDensityFactor) dip 0 file:///Users/build/Library/Developer/CoreSimulator/Device
ios.Titanium.UI #convertUnits() returns 100 mm = 10 cm 0 file:///Users/build/Library/Developer/CoreSimulator/Dev
ios.Titanium.UI #convertUnits() converts 1 in = dpi pixels 0 file:///Users/build/Li
ios.Titanium.UI #convertUnits() returns 1 in = 25.4 mm 0.001 file:///Users/build/Library/Developer/CoreSimulator/Devices
ios.Titanium.UI #convertUnits() returns 1 in = (dpi / logicalDensityFactor) dip 0.001 file:///Users/build/Library/Developer/Cor
ios.Titanium.UI #convertUnits() returns 1 in = 2.54 cm 0.001 file:///Users/build/Library/Developer/CoreSimulator/Devices/
ios.Titanium.UI #convertUnits() returns 2.54cm = dpi pixels 0.001 file:///Users/build/Library/Developer/CoreSimulator/Devic
ios.Titanium.UI #convertUnits() returns cm to mm as x * 10 0 file:///Users/build/Library/Developer/CoreSimu
ios.Titanium.UI #convertUnits() returns 1cm = 0.0393701 in 0 file:///Users/build/Library/Developer/CoreSimulator/Devices/6D5153
ios.Titanium.UI #convertUnits() returns 2.54 cm = (dpi / logicalDensityFactor) dip 0 file:///Users/build/Library/Developer/CoreSimulator/Device
ios.Titanium.UI.Layout TIMOB-23225 0.005 file:///Users/build/Li
ios.Titanium.UI.Layout TIMOB-23372 #7 0.006 file:///Users/build/L
ios.Titanium.UI.Layout TIMOB-23372 #6 0.004 file:///Users/build/L
ios.Titanium.UI.Layout TIMOB-23372 #5 0.009 file:///Users/build/L
ios.Titanium.UI.Layout TIMOB-23372 #4 0.004 file:///Users/build/L
ios.Titanium.UI.Layout TIMOB-23372 #3 0.003 file:///Users/build/L
ios.Titanium.UI.Layout TIMOB-23372 #2 0.003 file:///Users/build/L
ios.Titanium.UI.Layout layoutWithSIZE_and_fixed 0.003 file:///Users/build/L
ios.Titanium.UI.Layout scrollViewWithSIZE 0.007 file:///Users/build/L
ios.Titanium.UI.Layout sizeFillConflict 0.004 file:///Users/build/Li
ios.Titanium.UI.View backgroundGradient (linear) 10.003 file:///Users/build/Librar

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator Author

Ok, so this does not really work out. Will go with a different approach.

@hansemannn
Copy link
Collaborator Author

Closing as this does not seem to work out so far.

@hansemannn hansemannn closed this Aug 16, 2018
@hansemannn hansemannn removed this from the 7.4.0 milestone Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants