refactor(ios): address review feedback

tidev · Dec 11, 2020 · c94e6a2 · c94e6a2
1 parent 51b6428
commit c94e6a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/iphone/Classes/TiUIClipboardProxy.m b/iphone/Classes/TiUIClipboardProxy.m
@@ -301,7 +301,7 @@ - (bool)hasURLs
 - (void)setItems:(NSDictionary<NSString *, id> *)args
 {
   NSArray<NSDictionary<NSString *, id> *> *items = args[@"items"];
-  __block NSMutableArray<NSDictionary<NSString *, id> *> *result = [[[NSMutableArray alloc] init] retain];
+  __block NSMutableArray<NSDictionary<NSString *, id> *> *result = [[NSMutableArray alloc] init];
   // The key of the items must be a string (mime-type)
   for (NSDictionary<NSString *, id> *item in items) {
     NSMutableDictionary<NSString *, id> *newDict = [[NSMutableDictionary alloc] init];
@@ -348,9 +348,12 @@ - (void)setItems:(NSDictionary<NSString *, id> *)args
             } else if (UTTypeConformsTo((CFStringRef)key, kUTTypeImage)) {
               // Convert UIImage to TiBlob!
               newItem[key] = [[[TiBlob alloc] initWithImage:(UIImage *)item[key]] autorelease];
+            } else if ([key hasPrefix:@"dyn."]) {
+              [newItem removeObjectForKey:key];
             }
           }
           [result addObject:newItem];
+          [newItem release];
         }
       },
       YES);

diff --git a/iphone/Classes/UIModule.m b/iphone/Classes/UIModule.m
@@ -494,7 +494,7 @@ - (id)create3DMatrix:(id)args
 - (id)Clipboard
 {
   if (clipboard == nil) {
-    clipboard = [[[TiUIClipboardProxy alloc] _initWithPageContext:[self executionContext]] retain];
+    clipboard = [[TiUIClipboardProxy alloc] _initWithPageContext:[self executionContext]];
   }
   return clipboard;
 }