Skip to content

Commit

Permalink
fix(ios): source-maps property in tiapp.xml
Browse files Browse the repository at this point in the history
  • Loading branch information
Gary Mathews committed Aug 6, 2019
1 parent 8705100 commit 134dc9a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion iphone/cli/commands/_build.js
Original file line number Diff line number Diff line change
Expand Up @@ -1810,7 +1810,7 @@ iOSBuilder.prototype.validate = function validate(logger, config, cli) {
if (cli.argv['source-maps']) {
this.sourceMaps = true;
// if they haven't, respect the tiapp.xml value if set one way or the other
} else if (cli.tiapp.hasOwnProperty['source-maps']) { // they've explicitly set a value in tiapp.xml
} else if (cli.tiapp.hasOwnProperty('source-maps')) { // they've explicitly set a value in tiapp.xml
this.sourceMaps = cli.tiapp['source-maps'] === true; // respect the tiapp.xml value
} else { // otherwise turn on by default for non-production builds
this.sourceMaps = this.deployType !== 'production';
Expand Down Expand Up @@ -2609,6 +2609,9 @@ iOSBuilder.prototype.loginfo = function loginfo() {
} else {
this.logger.info(__('Set to copy files instead of symlinking'));
}

this.logger.info(__('Transpile javascript: %s', (this.transpile ? 'true' : 'false').cyan));
this.logger.info(__('Generate source maps: %s', (this.sourceMaps ? 'true' : 'false').cyan));
};

iOSBuilder.prototype.readBuildManifest = function readBuildManifest() {
Expand Down

0 comments on commit 134dc9a

Please sign in to comment.