fix: Fixed 'ti sdk install' silent fail when copying new modules to dest #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part of
ti sdk install
that copies the module files was wrapped in a try/catch, but didn't surface the error.The try/catch was basically a lazy catch when
fs.statSync(destDir).isDirectory()
throws fordestDir
not existing (e.g. new module found). Getting rid of the try/catch shows the error thatdestDir
doesn't exist, which was expected, however throwing was breaking out of all the nested loops when recursively copying the module files to the dest. The solution is to remove the try/catch and usefs.existsSync()
.This PR also resolves 2 other related issues.
ti setup user
author name prompt