UPLOAD-1409 - Enhanced error reporting

[vojtech-cerveny]

This pull request includes changes to enhance error reporting to Rollbar and update
Enhancements to error reporting:

• app/actions/utils.js: Modified the sendToRollbar function to handle the case when rollbar is not defined, and improved the error reporting by merging additional properties into the reported error.

By merging ...props to extra, application send also data included in uploadErrProps

      let uploadErrProps = {
        details: err.message,
        utc: getUtc(utc),
        name: err.name || 'Uncaught or API POST error',
        step: err.step || null,
        datasetId: err.datasetId || null,
        requestTrace: err.requestTrace || null,
        sessionTrace: err.sessionTrace || null,
        code: err.code || errCode,
        version: version,
        data: recs,
        loggedInUser: loggedInUser,
        userEmail: userEmail,
        userName: name,
        os: os,
        device: driverId,
      };

During testing it, I tried to upload data without connecting device and I got this error on rollbar.

And as you can see, ticket has new params - custom params added by this PR.

[gniezen]

Just a couple of small changes requested.

[gniezen]

@vojtech-cerveny I think we may need to be a bit more specific with which props we add. If the upload fails while uploading to the backend, I think there's a chance that the props will include all the data being sent (under props.data).

[vojtech-cerveny]

Well, I would say that I am OK with all data except props.data.

Because we send different objects into this function
For example:

        let disconnectedErrProps = {
          utc: actionUtils.getUtc(utc),
          code: 'E_HID_CONNECTION',
          version: version,
          loggedInUser: loggedInUser,
          userEmail: userEmail,
          userName: name,
          os: os,
          device: driverId,
        };

and

      let uploadErrProps = {
        details: err.message,
        utc: getUtc(utc),
        name: err.name || 'Uncaught or API POST error',
        step: err.step || null,
        datasetId: err.datasetId || null,
        requestTrace: err.requestTrace || null,
        sessionTrace: err.sessionTrace || null,
        code: err.code || errCode,
        version: version,
        data: recs,
        loggedInUser: loggedInUser,
        userEmail: userEmail,
        userName: name,
        os: os,
        device: driverId,
      };

so my solution would be to just delete props.data, WDYT?

    const extra = { ...props };
    delete extra.data;

[gniezen]

Yeah, I think that should be fine. I just did a test with Tandem where I made it fail during uploading to the backend and props.data included the raw packets, compressed binary blob, parsed records and raw records, so definitely exclude that one 😉

[gniezen]

LGTM! 🚢