Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add fill colors to render.Plot() #310

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Conversation

betterengineering
Copy link
Contributor

Overview

We support a line color, but not a fill color. This commit adds support for a fill color and an inverted fill color to override the alpha calculation.

Changes

This commit adds the ability to add a fill color to a plot to override
the alpha calculation.
@rs7q5
Copy link
Contributor

rs7q5 commented Jun 29, 2022

Does this mean I can alpha lines now!?!?

@betterengineering betterengineering merged commit d00fab8 into main Jun 29, 2022
@betterengineering betterengineering deleted the mark/add-plot-fill branch June 29, 2022 16:25
@betterengineering
Copy link
Contributor Author

betterengineering commented Jun 29, 2022

Does this mean I can alpha lines now!?!?

@rs7q5 you can now add a fill color to a chart. So a pink line and yellow fill if you so desire 😄 :

            render.Plot(
                width = 64,
                height = 24,
                data = data,
                fill_color = "#1C230D",
                color = "#95BF47",
                fill = True,
            ),

@rs7q5
Copy link
Contributor

rs7q5 commented Jun 29, 2022

Awesome, although I'm hoping we can have alpha lines next too :D but this is a great addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants