Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash calculation for widegts that have NaN values #267

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

rohansingh
Copy link
Member

The Plot widget now supports NaN values for some attributes. This
caused a problem when calculating hash, since we were getting the hash
by marshaling the render tree to JSON. Officially JSON doesn't support
NaN or inifinities.

Instead switch to marshaling to MessagePack. This is faster and supports
a wider range of data types.

The `Plot` widget now supports `NaN` values for some attributes. This
caused a problem when calculating hash, since we were getting the hash
by marshaling the render tree to JSON. Officially JSON doesn't support
`NaN` or inifinities.

Instead switch to marshaling to MessagePack. This is faster and supports
a wider range of data types.
@rohansingh rohansingh merged commit 720bc98 into main Apr 28, 2022
@rohansingh rohansingh deleted the rohan/fix-hash branch April 28, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant