Fix hash calculation for widegts that have NaN values #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Plot
widget now supportsNaN
values for some attributes. Thiscaused a problem when calculating hash, since we were getting the hash
by marshaling the render tree to JSON. Officially JSON doesn't support
NaN
or inifinities.Instead switch to marshaling to MessagePack. This is faster and supports
a wider range of data types.