Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: Allow config values that are not in the schema #126

Merged
merged 1 commit into from
Jan 17, 2022
Merged

runtime: Allow config values that are not in the schema #126

merged 1 commit into from
Jan 17, 2022

Conversation

rohansingh
Copy link
Member

If an app has schema, print a warning if we're passing config values
that are not in the schema.

@rohansingh
runtime: Allow config values that are not in the schema
42868d6 
If an app has schema, print a warning if we're passing config values
that are _not_ in the schema.
betterengineering
betterengineering approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@betterengineering betterengineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!!

@rohansingh rohansingh merged commit a555891 into main Jan 17, 2022
@rohansingh rohansingh deleted the rohan/schema-unknown branch January 17, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betterengineering betterengineering betterengineering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohansingh @betterengineering