Support app directories in all commands #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support multi-file app directories in remaining commands like `check`, `profile`, `lint`, etc. Note that `pixlet check` no longer supports the `-r` flag for recursively searching through a directory. This is because a single app can now contain subfolders with Starlark files, which should be checked and validated as part of the enclosing app. This change also removes spell-checking entirely.
rohansingh
force-pushed
the
rohan/bundle-cmds
branch
5 times, most recently
from
efe69ac
to
39fb0b5
Compare
* We were loading an applet by walking its entire source FS, but skipping any files outside of the root directory. Instead, just list and process the files in the root directory explicitly. * Move buildifier-based checks to the end of `pixlet check`, since they walk the entire directory tree. This means they won't run if there are any other errors, which are quicker to find.
rohansingh
force-pushed
the
rohan/bundle-cmds
branch
from
39fb0b5
to
15295ba
Compare
It can't find `webp/demux.h` any more for some reason.
rohansingh
force-pushed
the
rohan/bundle-cmds
branch
from
15295ba
to
c29ffd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multi-file app directories in remaining commands like
check,profile,lint, etc.Note that
pixlet checkno longer supports the-rflag for recursively searching through a directory. This is because a single app can now contain subfolders with Starlark files, which should be checked and validated as part of the enclosing app.This change also removes spell-checking entirely.