Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve GIF file instead of webp in server mode #1005

Closed
jdesai61 opened this issue Feb 1, 2024 · 1 comment
Closed

Serve GIF file instead of webp in server mode #1005

jdesai61 opened this issue Feb 1, 2024 · 1 comment

Comments

@jdesai61
Copy link

jdesai61 commented Feb 1, 2024

Currently render command has a switch (--gif) to create a GIF file. But when you use serve command, this option is missing. I am trying to use this with a device than doesn't have webp available, but GIF is supported. Is it possible to add such support? Thanks

@rohansingh
Copy link
Member

Definitely open to a PR for this (pixlet serve --gif).

dinosaursrarr added a commit to dinosaursrarr/tidbyt-pixlet that referenced this issue Apr 30, 2024
Saw tidbyt#1005 and thought it was a fun little challenge.

Tested that this worked locally for:
 - Previewing with WebP (default)
 - Previewing with GIF (passing --gif flag)
 - Updating config using either format
 - Exporting image using either format

Inspected the images shown and confirmed that it does generate a WebP or GIF file as appropriate, and that the src element is set to the appropriate image type.
dinosaursrarr added a commit to dinosaursrarr/tidbyt-pixlet that referenced this issue Apr 30, 2024
Saw tidbyt#1005 and thought it was a fun little challenge.

Tested that this worked locally for:
 - Previewing with WebP (default)
 - Previewing with GIF (passing --gif flag)
 - Updating config using either format
 - Exporting image using either format

Inspected the images shown and confirmed that it does generate a WebP or GIF file as appropriate, and that the src element is set to the appropriate image type.
rohansingh pushed a commit that referenced this issue May 2, 2024
Saw #1005 and thought it was a fun little challenge.

Tested that this worked locally for:
 - Previewing with WebP (default)
 - Previewing with GIF (passing --gif flag)
 - Updating config using either format
 - Exporting image using either format

Inspected the images shown and confirmed that it does generate a WebP or GIF file as appropriate, and that the src element is set to the appropriate image type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants