Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTestFrameworkPkg: Use TianoCore mirror of subhook submodule #6407

Conversation

mdkinney
Copy link
Member

@mdkinney mdkinney commented Nov 5, 2024

Cherry-pick from PR #6402 to apply same change to edk2-stable202408.

Description

Change subhook url from https://github.com/Zeex/subhook to https://github.com/tianocore/edk2-subhook because old url is no longer available.

Also align .gitmodules file to use consistent LF line endings.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Integration Instructions

Change subhook url from https://github.com/Zeex/subhook to
https://github.com/tianocore/edk2-subhook because old url is
no longer available.

Also align .gitmodules file to use consistent LF line endings.

Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Copy link
Member

@leiflindholm leiflindholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer functional/non-functional split, but I'm not going to insist since this form was already merged into the default branch.

@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Nov 6, 2024
@mergify mergify bot merged commit 4dfdca6 into tianocore:stable/202408 Nov 6, 2024
106 checks passed
@benjamindoron
Copy link
Contributor

benjamindoron commented Nov 25, 2024

Thoughts on backporting this further, to prior releases, or creating some other solution for consumers on older tags? I do worry though at the number of tags this would create. Maybe it's an opportunity to select a couple more stable tags to turn into stable/(stable-date) branches, to serve as some "LTS" that gets critical fixes.

@mdkinney
Copy link
Member Author

Thoughts on backporting this further, to prior releases, or creating some other solution for consumers on older tags? I do worry though at the number of tags this would create. Maybe it's an opportunity to select a couple more stable tags to turn into stable/(stable-date) branches, to serve as some "LTS" that gets critical fixes.

For older tags, one option is to add the following to your local .gitconfig file.

[url "https://github.com/tianocore/edk2-subhook.git"]
      insteadOf = https://github.com/Zeex/subhook.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants