-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update openssl to 3.2.x #5765
update openssl to 3.2.x #5765
Conversation
78c7225
to
eeb0721
Compare
5665971
to
8c9a5ba
Compare
fbfdd4f
to
e527e4e
Compare
Is there any special reason to upgrade to 3.2? If you don't need the new features in 3.2, 3.0 is probably a better choice. |
Mostly that others (Fedora distro for example) moved from 3.0 to 3.2 too. |
Then I prefer to stay at LTS version due to no new features needed by EDK2. |
Usually, I am OK to upgrade, as long as there is no much size difference. Also, as @liyi77 mentioned, @kraxel , do you want to go back to 3.0 after November 2025? |
Will be needed by openssl-3.2.x Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Turn gettimeofday() into a proper function with return value. Will be needed by openssl-3.2.x Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
No functional change. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Will be needed by openssl-3.2.x Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Adding $(OPENSSL_PATH)/e_os.h to the list of source files had the effect that $(OPENSSL_PATH)/ was added to the list of include directories. With the file being gone in openssl-3.2.x this doesn't work any more. Add the directory to the [Includes.Common.Private] section instead. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Function declarations have changed in openssl-3.2.x, adapt the stubs. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
openssl-3.2.2 got a few more tls config hooks, add stubs for them. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Fix for openssl is on the way and should land in 3.2.3 openssl/openssl#24895 After updating the openssl submodule to a version with the fix included it should be possible to revert this patch. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ovmf pei firmware volume does not change in size.
openssl started to do two releases per year, in april and november. Since I've started working on this 3.3 has been released, which will be supported until April 2026. Moving to 3.3 seems to work fine (builds on linux without additional changes, did not try CI yet). 3.4 should follow later this year, will supported until november 2026 (maybe even longer should it become an LTS release), which is beyond the 3.0 LTS EOL date. So there clearly is no need to go back to 3.0 |
e527e4e
to
f3706ce
Compare
8407380
to
0de4efb
Compare
aarch64 switching to asm acceleration breaks the build with openssl 3.2 (also 3.3 and 3.4) due to an openssl bug. |
Downgraded this to draft for now, waiting for the openssl fix to land upstream. Moved the version-independent changes to a new PR (#6185), |
It seems the size delta is acceptable. Thanks @kraxel. I feel we should always use the LTS branch. |
Yes, we can also jump to 3.4. It is not clear whenever it will become an LTS release, but even in case that does not happen the EOL date will be after 3.0-LTS goes EOL. |
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
PR can not be merged due to conflict. Please rebase and resubmit |
closing, working on 3.4.x update instead. |
Description
The second part of the series (all 'openssl:' prefixed patches) is not
bisectable, all patches are needed to make edk2 build again. The only
way to fix that would be to squash them all together. That would make
review rather hard though, especially due to the large "update generated
files" patch.
How This Was Tested
Integration Instructions
N/A