Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference argument to submodule update --init invocations #842

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

joschock
Copy link
Contributor

@joschock joschock commented Jul 2, 2024

When resolving a repo with submodules via the repo_resolver::checkout() method, the reference argument (if appropriate) was not used for submodule updates as part of resolution. This PR adds support for the reference argument to allow references to be used throughout the resolution process.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (bf643b0) to head (6f75785).
Report is 74 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   78.75%   78.45%   -0.30%     
==========================================
  Files          49       40       -9     
  Lines        4909     4897      -12     
==========================================
- Hits         3866     3842      -24     
- Misses       1043     1055      +12     
Files Coverage Δ
edk2toolext/environment/repo_resolver.py 91.53% <66.66%> (+1.15%) ⬆️

... and 48 files with indirect coverage changes

@Javagedes Javagedes added the enhancement New feature or request label Jul 3, 2024
@Javagedes Javagedes added this to the 0.27.9 milestone Jul 3, 2024
@Javagedes Javagedes enabled auto-merge (squash) July 3, 2024 23:35
@Javagedes Javagedes merged commit a4d97cd into tianocore:master Jul 3, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants