Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date writer #55

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Fix date writer #55

merged 1 commit into from
Dec 16, 2020

Conversation

sakalauskas
Copy link
Contributor

For numeric values, we only need to increment $nominalIdx by 1. With date having width of 20, Utils::widthToOcts($var->width) returns 3 and $nominalIndex is no longer correctly calculated as it shifts subsequent variables too far.

@sakalauskas
Fix tiamo#53
ec2682d 
For numeric values, we only need to increment $nominalIdx by 1. With date having width of 20, Utils::widthToOcts($var->width) returns 3 and $nominalIndex is no longer correctly calculated as it shifts subsequent variables too far.
@sakalauskas sakalauskas changed the title Fix for dates #53 Fix for dates writer Dec 16, 2020
@sakalauskas sakalauskas changed the title Fix for dates writer Fix date writer Dec 16, 2020
@tiamo
Copy link
Owner

tiamo commented Dec 16, 2020

@sakalauskas Thanks!

@tiamo tiamo merged commit 6faf9f8 into tiamo:master Dec 16, 2020
@sakalauskas
Copy link
Contributor Author

@tiamo oops, I tagged incorrect issue in the commit comment. This PR should close #36 but not the #53.

@tiamo
Copy link
Owner

tiamo commented Dec 16, 2020

@sakalauskas ok )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakalauskas @tiamo