Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ws auth when subaccounts are used #7

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Fix ws auth when subaccounts are used #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7cb13c
fix(#6): pass subaccount to ws auth if provided
qbkjovfnek Apr 29, 2021
996dad4
v1.0.4: fix ws auth for subaccounts
qbkjovfnek Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ftx-api",
"version": "1.0.3",
"version": "1.0.4",
"description": "Node.js connector for FTX's REST APIs and WebSockets",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
3 changes: 2 additions & 1 deletion src/websocket-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export class WebsocketClient extends EventEmitter {
}

private requestTryAuthenticate(wsKey: string) {
const { key, secret } = this.options;
const { key, secret, subAccountName } = this.options;
if (!key || !secret) {
this.logger.debug(`Connection "${wsKey}" will remain unauthenticated due to missing key/secret`);
return;
Expand All @@ -171,6 +171,7 @@ export class WebsocketClient extends EventEmitter {
key,
signWsAuthenticate(timestamp, secret),
timestamp,
subAccountName,
);
this.tryWsSend(wsKey, JSON.stringify(authMsg));
}
Expand Down