Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket-client didn't pass subaccount name to authenticate #6

Closed
kangchihlun opened this issue Apr 29, 2021 · 2 comments · Fixed by #7
Closed

websocket-client didn't pass subaccount name to authenticate #6

kangchihlun opened this issue Apr 29, 2021 · 2 comments · Fixed by #7

Comments

@kangchihlun
Copy link

ftx-api/src/websocket-client.ts

Line 173 in 6d57ba5

timestamp,

message for private channel of sub account didn't work.
tiagosiebler pushed a commit that referenced this issue Apr 29, 2021
@qbkjovfnek
fix(#6): pass subaccount to ws auth if provided
c7cb13c
@tiagosiebler tiagosiebler mentioned this issue Apr 29, 2021
Merged
@tiagosiebler
Copy link
Owner

@kangchihlun good catch - I've pushed a fix for this. Can you try the latest version (v1.0.4) and confirm?

npm install ftx-api@latest

Thanks for reporting this!

@kangchihlun
Copy link
Author

It works ! much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ws auth when subaccounts are used tiagosiebler/ftx-api
2 participants
@kangchihlun @tiagosiebler