Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pingcap/tidb): disable github review approve and codeowner required options #945

Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Aug 7, 2023

Disable the required options in branch protect rule for master branch.
Prepare for enable congfiguration owner approving mechanism.

Signed-off-by: wuhuizuo wuhuizuo@126.com

What problem does this PR solve?

Issue Number: ref pingcap/tidb#45183
Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

…ired options

Disable the required options in branch protect rule for master branch.
Prepare for enable congfiguration owner approving mechanism.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 7, 2023 06:52
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2023
@wuhuizuo wuhuizuo added the lgtm label Aug 7, 2023
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Aug 7, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 20e2170 into main Aug 7, 2023
@ti-chi-bot ti-chi-bot bot deleted the feature/disable-codeowner-required-options-for-tidb-master branch August 7, 2023 14:13
wuhuizuo added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant