add default html to test environment #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Oct 5, 2017
testEnvironment.js
Outdated
| @@ -13,7 +13,9 @@ class JSDOMEnvironment { | |||
| // lazy require | |||
| const {JSDOM} = require('jsdom'); | |||
|
|
|||
| this.document = new JSDOM(undefined, { | |||
| const html = '<!DOCTYPE HTML><html lang="en"><head><title>Test Environment</title></head><body></body></html>' | |||
There was a problem hiding this comment.
Oh, forgot about that! I think we only need the doctype, no?
There was a problem hiding this comment.
I think that would suffice! Maybe remove the <title></title>
There was a problem hiding this comment.
new JSDOM('<!doctype html>, { should be good :)
|
Ok, I updated the branch |
thymikee
approved these changes
Oct 8, 2017
|
4.0.1 published, enjoy! |
sharikovvladislav
added a commit
to sharikovvladislav/jest-preset-angular
that referenced
this pull request
Nov 28, 2017
* origin/master: Adds a warning about html transforms. (thymikee#94) Update README to include installation instructions. (thymikee#84) Add doctype to test environment (thymikee#78) v4.0.0 v4.0.0 changelog Update changelog for master v4.0.0-alpha.1 Use universal zone.js instead of node-only (thymikee#76) Add custom environment (thymikee#75) Add fakeAsync test v3.0.2 Clarify AngularJS support More accurate moduleNameMapper regexps (thymikee#71) Update CHANGELOG.md v3.0.1 Bump jest and ts-jest to v21 (thymikee#70) v3.0.0 Tighten up module mappers; bump jest (thymikee#53) Add section to troubleshooting about JS files transpiling (thymikee#68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix Angular Material tests, a default HTML shell should be used
This change fixes the following console warnings
PASS src/client/app/+admin/admin.component.spec.ts ● Console console.warn node_modules/@angular/material/bundles/material.umd.js:206 Current document does not have a doctype. This may cause some Angular Material components not to behave as expected. console.warn node_modules/@angular/material/bundles/material.umd.js:206 Current document does not have a doctype. This may cause some Angular Material components not to behave as expected.