feat(compiler): use replace-resources transformer from Angular for isolatedModules: true
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy source code of TypeScript `transpileModule` so that we can get `Program` which is created in that function which then allows us to use `replace-resources` transformer from Angular BREAKING CHANGE - `inline-files` and `strip-styles` are removed from `jest-preset-angular` and now `jest-preset-angular` always uses Angular `replace-resources` instead for both `isolatedModules: false` and `isolatedModules: true`. - Users who are using `inline-files` and `strip-styles` transformers in jest config ``` 'jest-preset-angular/build/InlineFilesTransformer', 'jest-preset-angular/build/StripStylesTransformer', ``` must be removed
ahnpnl
added
the
💣 Breaking Changes
ahnpnl
changed the title
replace-resources for isolatedModules: truereplace-resources transformer from Angular for isolatedModules: true
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copy source code of TypeScript
transpileModuleso that we can getProgramwhich is created in that function which then allows us to usereplace-resourcestransformer from Angular.This also provides fully compatibility to ESM for
isolatedModules: true, related to #710Test plan
Adjusted unit tests, green CI
Does this PR introduce a breaking change?
inline-filesandstrip-stylesare removed fromjest-preset-angularand nowjest-preset-angularalways uses Angularreplace-resourcesinstead for bothisolatedModules: falseandisolatedModules: true.inline-filesandstrip-stylestransformers in your jest configmust be removed
Other information
N.A.