Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler #543

Closed
wants to merge 8 commits into from
Closed

Compiler #543

wants to merge 8 commits into from

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 8, 2020

This branch managed to fix the issue with entry component #353 but it failed on other tests, some tests even hang.

ahnpnl and others added 8 commits October 6, 2020 21:55
Override `configsFor` of `TsJestTransformer` from `ts-jest` in our `AngularJestTransformer` to initialize our config class `NgJestConfig`.

This will ensure that later `AngularJestTransformer` can use Angular compiler with correct compiler config to compile codes.
Bumps [@jest/transform](https://github.com/facebook/jest/tree/HEAD/packages/jest-transform) from 26.5.0 to 26.5.2.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v26.5.2/packages/jest-transform)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pretty-format](https://github.com/facebook/jest/tree/HEAD/packages/pretty-format) from 26.5.0 to 26.5.2.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v26.5.2/packages/pretty-format)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jest](https://github.com/facebook/jest) from 26.5.0 to 26.5.2.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](jestjs/jest@v26.5.0...v26.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) from 10.1.4 to 10.1.5.
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/master/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/10.1.5/packages/core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
`NgJestCompiler` takes care of compiling files and return a string which is the compiled output concatenating with source map string. The compiler also does type checking.
@ahnpnl ahnpnl mentioned this pull request Oct 8, 2020
@wtho
Copy link
Collaborator

wtho commented Oct 15, 2020

What's the status? Do you have an idea why tests tend to hang?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Oct 15, 2020

after ngcc, running tests hang due to Converting circular structure to JSON exception. I haven't looked into it more yet. It also can be that the compiler codes are not completed, not so sure.

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Oct 16, 2020

I will create another draft PR. The branch on this PR is a bit messy

@ahnpnl ahnpnl closed this Oct 16, 2020
@ahnpnl ahnpnl deleted the compiler branch October 26, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants