feat: use simpler reflect-metadata implementation #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtho
force-pushed
the
feat/internal-reflect-metadata
branch
from
57c3f56 to
c580f02
Compare
wtho
force-pushed
the
feat/internal-reflect-metadata
branch
2 times, most recently
from
1de9778 to
d12c6ce
Compare
|
I see this is quite stripped version. I'd suspect Angular may at any point increase/decrease their reflect-metadata usage. So it would be nice to provide an escape hatch to load core-js in such cases. Documenting it should be enough imho |
* remove core-js dependency in preset * remove core-js import tests * add small reflect metadata lib * add test for relfect metadata lib * update typescript version in preset to current
wtho
force-pushed
the
feat/internal-reflect-metadata
branch
from
d12c6ce to
e8761c6
Compare
|
Added documentation regarding reflection to troubleshooting |
thymikee
approved these changes
Oct 18, 2019
thymikee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look especially at
reflectMetadata.ts. Note that we surely are not proposal-compliant with this implementation, but this is minimal to what Angular uses.also choreshandled in #316 insteadexample app: remove codelyzer dependencyexample app: fix asset path in calc.componentexample app: add "node" type in tsconfig.app.json to require assetIf you want I can split the chores out to an own PR/commit.Closes #314.