Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support outputFromObservable and input.required #2389

Closed
wants to merge 1 commit into from

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 20, 2024

Summary

See commits

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl force-pushed the test/update-examples-for-signals branch 2 times, most recently from 095cc97 to 64029bf Compare April 20, 2024 21:13
@ahnpnl ahnpnl force-pushed the test/update-examples-for-signals branch from 64029bf to b2fa591 Compare May 6, 2024 04:51
@ahnpnl ahnpnl marked this pull request as draft May 6, 2024 06:55
@ahnpnl ahnpnl closed this May 7, 2024
@ahnpnl ahnpnl deleted the test/update-examples-for-signals branch May 7, 2024 06:41
@daniMoralesDachser
Copy link

Is it working now with 14.0.4 version?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 8, 2024

Should be, this PR was just an attempt to add example tests but was done in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants