-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update project to Angular 17 #2185
Conversation
This change updates root dependencies to use Angular 17. It also introduces a new example project with a fully standalone v17 app for testing. Note: updating to the latest prettier / eslint resulted in some minor formatting updates.
5845056
to
67162b0
Compare
@ahnpnl Curious how you'd like to deal with this kind of code. If we upgrade TS in the root to 5.2, several props used in this code don't exist anymore. Would you prefer to keep the root version of TS lower to support this compatibility layer, or take it out and increase min version support? |
The files in According to Angular support policy, after 22th Nov 2023, the minimum supported version is v15. That means the files in The files in If some codes have been removed in v17, but still exists in v15 and v16, we need to:
|
Great. thanks for the background. I'll look at the new versions of these files |
Yeah, I didn't anticipate the TypeScript compatibility work that's ultimately required to land this Angular upgrade. Realistically, it'll be at least another couple weeks before I can get back on this and start to work through that refactor. Since the TypeScript upgrade could be done separately, if anyone else wants to jump in and do that as a separate change, please feel free. |
Continue in #2198 |
Thanks for wrapping this up. Apologies for the delay on my end. We had a long holiday. |
Summary
This change updates root dependencies to use Angular 17. It also introduces a new example project with a fully standalone v17 app for testing.
Note: updating to the latest prettier / eslint resulted in some minor formatting updates.
Does this PR introduce a breaking change?
Other information
The
esm
andesm-isolated
tests under the new example 17 project were timing out for me, but I wasn't sure if that was just something wrong with my local environment, since I've not run this project locally before. It would be good to confirm that these are running successfully. If not, I may need some guidance on what might be the issue. Might be related to this issue #2138