Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: File separator issue on Windows causing error: jest: got error running globalsetup cannot find module @angular\compiler-cli #2079

Merged
merged 2 commits into from
May 9, 2023

Conversation

pal03377
Copy link
Contributor

@pal03377 pal03377 commented May 8, 2023

Summary

This fixes #2073

Test plan

  • git clone https://github.com/pal03377/jest-preset-angular somewhere else
  • cd jest-preset-angular from there
  • npm install, then npm run build
  • npm link to locally link this repo
  • cd path/to/minimal-example from here https://github.com/pal03377/minimal-jest-pathsep-issue
  • npm install, then npm link jest-preset-angular
  • npm run test to verify that it now works

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ahnpnl ahnpnl merged commit b6b3911 into thymikee:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants