perf(transformer): leverage the ts-jest config set cache #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating ConfigSet instances all the time (which is an expensive operation, as it involves path concatenations, merging configurations, reading from disk...), we use a private method in `ts-jest` that caches the configurations. Inspired by the discussions in thymikee#1313. This is the result of applying this patch to one of our small projects: Before: Test Suites: 6 skipped, 59 passed, 59 of 65 total Tests: 7 skipped, 370 passed, 377 total Snapshots: 0 total Time: 63.066 s After: Test Suites: 6 skipped, 59 passed, 59 of 65 total Tests: 7 skipped, 370 passed, 377 total Snapshots: 0 total Time: 58.326 s
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of creating
ConfigSetinstances all the time (which is an expensive operation, as it involves path concatenations, merging configurations, reading from disk...), we use a private method ints-jestthat caches the configurations.Kind of a follow-up to #1310 and inspired by the discussions in #1313.
This patch results in significant decrease in the execution time of our test harness: from 821s to 694s.
Test plan
npm testis passing. Our test harness runs without any issues with this patch.Does this PR introduce a breaking change?
Other information