perf(transformer): cache useNativeEsbuild result #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the result will be the same for all transformer instances we can cache the result, thus avoiding resolving and spawning redundant processes. For a test harness with ~3800 tests grouped in ~110 projects this translates to a reduction in running time of ~20s.
ahnpnl
reviewed
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the result will be the same for all transformer instances we can cache the result, thus avoiding resolving and spawning redundant processes.
For a test harness with ~3800 tests grouped in ~110 projects this translates to a reduction in running time of ~20s. Attaching a screenshot of the profile that shows how instantiation takes ~20s.
Test plan
The existing tests are passing (
npm test). Our existing test harness runs without any issues with this patch.Does this PR introduce a breaking change?
Other information