Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more troubleshooting docs #129

Merged
merged 7 commits into from
Mar 10, 2018
Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Mar 2, 2018

Closes #86

@thymikee thymikee requested a review from ahnpnl March 2, 2018 14:06
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look clear to me. Thank you 👍

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 9, 2018

@Hotell sorry I reviewed quite late. If you don't mind, would you please including your example into the example app of the repo ? That would be nice as a place where we have some particular testing examples for Angular app.

@Hotell
Copy link
Contributor Author

Hotell commented Mar 9, 2018

oh ! no worries :D I almost forgot that I did the PR , will include those ASAP !

@Hotell
Copy link
Contributor Author

Hotell commented Mar 9, 2018

@AhnpGit example app updated, pls re-review, thx

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 10, 2018

@Hotell thank you 👍
cc @thymikee

@thymikee thymikee merged commit c57a4b5 into thymikee:master Mar 10, 2018
@thymikee
Copy link
Owner

Thank you guys, you rock!

@Hotell Hotell deleted the mh/more-docs branch March 11, 2018 16:47
@Hotell
Copy link
Contributor Author

Hotell commented Mar 11, 2018

👌🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants