Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(devs-infra): allow reflection/src to be in published content #1135

Merged
merged 1 commit into from
Nov 4, 2021
Merged

build(devs-infra): allow reflection/src to be in published content #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ examples

# sources are inlined
src
!build/ngtsc/reflection/src

# Development scripts
scripts
Expand Down
12 changes: 2 additions & 10 deletions scripts/test-examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ const execa = require('execa');
const logger = require('./logger');
const { exampleAppsToRun, rootDir } = require('./paths');

const jestArgs = process.argv.slice(3);

const executeTest = (projectPath) => {
// we change current directory
process.chdir(projectPath);
Expand Down Expand Up @@ -38,14 +36,8 @@ const executeTest = (projectPath) => {
});

// then we can run the tests
const cmdLine = ['yarn', 'test'];
const cmdESMLine = ['yarn', 'test-esm'];
if (jestArgs.length) {
cmdLine.push('--');
cmdESMLine.push('--');
cmdLine.push(...jestArgs);
cmdESMLine.push(...jestArgs);
}
const cmdLine = ['yarn', 'test', '--no-cache'];
const cmdESMLine = ['yarn', 'test-esm', '--no-cache'];

logger.log('starting the CommonJS tests using:', ...cmdLine);
logger.log();
Expand Down