Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Jest without Zone (noNgZone). #354

Closed
x47188 opened this issue Feb 29, 2020 · 15 comments · Fixed by #2825
Closed

Angular: Jest without Zone (noNgZone). #354

x47188 opened this issue Feb 29, 2020 · 15 comments · Fixed by #2825
Labels
🚀 Feature Request new suggested feature

Comments

@x47188
Copy link

x47188 commented Feb 29, 2020

Hey 🙌

I was wondering if there was any documented way to run Angular 9 + Jest without zone.js ( setupJest.ts heavily relies on Zone)?

@wtho
Copy link
Collaborator

wtho commented Mar 2, 2020

Hey!

No, we just got into the first compatibility issues with Angular 9, so there's no work done on this field so far.
But you can try removing these imports in your project and report your findings!

@x47188
Copy link
Author

x47188 commented Mar 2, 2020

Removing the zone imports will raise an In this configuration Angular requires Zone.js error at boot.

Some interesting findings:

  • I'm not getting a TestBedRender3 instance from getTestBed() (probably related to the fact that I'm not using ngcc-compiled Ivy bundles).

  • Nothing is available inside current TestBedViewEngine or TestBedRender3 implementations to easily disable Zone.js (that noNgZone flag could be a potential answer though).

  • I tried toying with the injection container replacing NgZone value with a NoopNgZone etc... without success.

@ahnpnl ahnpnl added the ivy Ivy compatible label Mar 3, 2020
@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 3, 2020

I remember I tried this before, with Angular 8 or lower I also got some similar errors so I gave up about excluding zone. Angular looks like tightly coupled with zone

@wtho
Copy link
Collaborator

wtho commented Mar 3, 2020

@x47188 but if I interpret the issue right, you do have an app that runs without zone.js and you want to achieve the same in jsdom for jest, is that the case?
Then I think we should look into it.

@x47188
Copy link
Author

x47188 commented Mar 4, 2020

but if I interpret the issue right, you do have an app that runs without zone.js and you want to achieve the same in jsdom for jest, is that the case?

Absolutely.

Then I think we should look into it.

Very appreciated!

However I fear the current TestBedRender3 implementation isn't flexible enough to allow ivy-only zonejs-less rendering.

@wtho
Copy link
Collaborator

wtho commented Mar 13, 2020

Do your zoneless tests run in Karma?

@x47188
Copy link
Author

x47188 commented Mar 25, 2020

@wtho good question, I'll create a "repro" to verify that. (I've striped karma & co from my current code-base)

@wtho
Copy link
Collaborator

wtho commented Mar 25, 2020

Thanks, if you could also share it, that would be awesome!

@wtho wtho added the Needs Repo Need a minimium repository to reproduce the problem label Jul 8, 2020
@wtho wtho mentioned this issue Jul 9, 2020
@ahnpnl
Copy link
Collaborator

ahnpnl commented Dec 1, 2020

I think this depends on the development from Angular to work without zone, which is currently in roadmap https://angular.io/guide/roadmap#leverage-full-framework-capabilities-with-zonejs-opt-out

@ahnpnl ahnpnl closed this as completed Apr 30, 2021
@ahnpnl ahnpnl added Not An Issue Not jest-preset-angular issue and removed Needs Repo Need a minimium repository to reproduce the problem ivy Ivy compatible labels Apr 30, 2021
@igorzablotny
Copy link

@ahnpnl Hi, since angular 18 features experimental zoneless support, is that planned for the near future? Right now in the application without zone, importing preset with import 'jest-preset-angular/setup-jest'; throws an error, since zone is not loaded in zoneless application.

Cannot find module 'zone.js' from 'node_modules/jest-preset-angular/setup-jest.js'

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 24, 2024

Hi, yes I think if we can rely on a flag from angular package to detect when zone is available to import, it should be easy to implement into the existing setup file.

If there is no such flag, i think we might need a separate setup file for testing zoneless application.

PR is welcome :)

@ahnpnl ahnpnl reopened this May 24, 2024
@ahnpnl ahnpnl added 🚀 Feature Request new suggested feature and removed Not An Issue Not jest-preset-angular issue labels May 24, 2024
@ahnpnl ahnpnl changed the title Angular9: Jest + Ivy without Zone (noNgZone). Angular: Jest + Ivy without Zone (noNgZone). May 24, 2024
@ahnpnl ahnpnl changed the title Angular: Jest + Ivy without Zone (noNgZone). Angular: Jest without Zone (noNgZone). May 24, 2024
@meierw
Copy link

meierw commented Jun 1, 2024

This currently is a blocker for us to start using Zoneless apps in Angular 18. Would love to see a fix 🙇

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jun 1, 2024

You can simply copy the content of setup-jest.js and remove zone import.

@meierw
Copy link

meierw commented Jun 1, 2024

Ok it was a bit of an ordeal that I had to go through. Cause I was using @angular-builders/jest.

Even though I understood from the docs that @angular-builders/jest merges it's config with the user config. I still couldn't get all the correct config values to work and overwrite the base config that @angular-builders/jest had under the hood.

In the end I completely ripped out @angular-builders/jest in favor of just using jest directly.

Now my jest config looks like this and works with provideExperimentalZonelessChangeDetection() everywhere. In my app config as well as in my TestBed providers.

// package.json
{  
  "jest": {
    "preset": "jest-preset-angular",
    "setupFilesAfterEnv": [
      "<rootDir>/jest.setup.ts"
    ]
  }
}
// jest.setup.ts
import { getTestBed } from "@angular/core/testing"
import {
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting,
} from "@angular/platform-browser-dynamic/testing"

const testEnvironmentOptions =
  (globalThis as any).ngJest?.testEnvironmentOptions ?? Object.create(null)

getTestBed().initTestEnvironment(
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting(),
  testEnvironmentOptions,
)

Thanks. @ahnpnl for the hint of just copying the setup code.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jun 2, 2024

Besides, I asked Angular team and they also suggested to include this https://github.com/angular/components/blob/04d3b63de2fb843beb55836e39e930c3342d26f1/test/angular-test-init-spec.ts#L35

I think in the next major release, we can provide function to call instead of implicitly calling setup TestBed upon import like current way.

Providing function call to setup Jest will be more flexible instead of relying on globalThis

ahnpnl added a commit that referenced this issue Nov 15, 2024
@ahnpnl ahnpnl closed this as completed in 21c0238 Nov 15, 2024
@ahnpnl ahnpnl unpinned this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature Request new suggested feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants