-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jest 24 #224
feat: Jest 24 #224
Conversation
* origin/release/7:
it's necessary to add it/test.todo support to fix this error: |
is it to add to |
Yup, it's there. I'll update the PR later today (or feel free to do that for me instead, you can push to this branch) |
Hi, it seems like development on this has been paused. Can this be prioritized because of the security vulnerability with Are there any blockers? |
I don't see any blockers. Only one feature nice to have is it/test.todo support |
This is a PoC. Jest 24 works without any changes from our side. It added some defaults to TS but we use slightly different ones (e.g. no `.tsx`). However, until `ts-jest` updates, we'll likely need to hold off with the upgrade, because of peer dep warnings. Fixes #223
Just finished reading all and it was merged 🤣 |
Released as |
Will try immediately 👌 |
Looks good to me, was able to integrate into Nx. Looking forward to the stable :) |
apart from performance downgraded, I don't see any issues. |
We discuss perf regression here jestjs/jest#8032 If you have anything valuable to add, that would be great! |
I think originally the performance was affected by |
Just to be sure, you're on 24.1, right? We had a caching regression in 24.0 fixed in minor |
ya I was on 24.1. In my opinion mainly the performance is caused by ast transformer. |
Is a stable version blocked by these performance issues? |
Nope, I think we should finally release it :p |
👍 from my side |
Actually the performance is not so bad. Only the 1st time jest needs to recache things and after that 2nd time all the tests finished with a more less similar amount of time for my work's project comparing to v6 |
This is a PoC. Jest 24 works without any changes from our side. It added some defaults to TS but we use slightly different ones (e.g. no
.tsx
).However, until
ts-jest
updates, we'll likely need to hold off with the upgrade, because of peer dep warnings.Fixes #223