Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Jest 29 [follow-up] #1937

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Conversation

Michsior14
Copy link
Contributor

Summary

Follow-up PR of @Tommy228 (#1901) and @tja4472 (https://github.com/Tommy228/jest-preset-angular/pull/1) work introducing support for jest 29 including fixed tests and documentation.

Test plan

Tested by @Tommy228 and by running tests inside of examples folder.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Same as in #1901

Ismaïl Ouazzany and others added 6 commits January 27, 2023 06:32
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ahnpnl ahnpnl merged commit b0b57a7 into thymikee:main Jan 27, 2023
@ahnpnl ahnpnl mentioned this pull request Jan 27, 2023
5 tasks
@Tommy228
Copy link

Thanks @Michsior14 for following that up.

@maks-humeniuk
Copy link

The error ts-jest[ts-jest-transformer] (WARN) Define ts-jest config under globals is deprecated still reproduces in v13.1.1. Jest version is 29.6.1, Angular – 12.

@krzysztofbogusz91
Copy link

krzysztofbogusz91 commented Aug 16, 2023

Hello, also facing same issue. The only solution was downgrade.
For angular 15 with:
"@angular-builders/jest": "^15.0.0",
downgrade to:
"@types/jest": "28.1.1",
"jest": "28.0.0",
"jest-preset-angular": "12.2.6",

It seems that as using the @angular-builders/jest has dependency on "jest-preset-angular": "12.2.6", there seems to be conflict with newer packages in local project.

@maks-humeniuk
Copy link

@krzysztofbogusz91, thanks, it worked!

@maks-humeniuk
Copy link

But that's not how it's supposed to work, right?

@Michsior14 @Tommy228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants