Use github actions, refactor tests and remove all unsupported versions of ruby/rails #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry that I'm just getting to this now. This looks good! I see you've been doing other work on your master branch so just double checking that this PR is still good to merge from your perspective? |
|
@thuss perhaps we can just go with this as-is? I've been looking at what's required to get this library to support Rails 7.1 and it seems like this (or equivalently? #172), along with #171 would be good to get merged Once those are in, I'm happy to try and figure out any remaining issues to get this library working with 7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting Ruby 3.2.0 and rails 7.0 as tests are red with these versions. Will add this in an additional PR.
EDIT: AR 7.0 support is in my fork master along with ruby 3.2 support.