Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drawer account view #8136

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Add drawer account view #8136

merged 4 commits into from
Sep 12, 2024

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Sep 11, 2024 •
edited
Loading

Add new drawer AccountView.

AccountView

Resolves #8120

@wmontwe wmontwe requested a review from cketti as a code owner September 11, 2024 12:55
@wmontwe wmontwe force-pushed the add-drawer-account-top-view branch from 9ea1b4e to cd60d99 Compare September 11, 2024 14:22
cketti
cketti approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from DrawerViewModel.updateAccounts() (see comment) this looks good to me.

...navigation/drawer/src/main/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerViewModel.kt Outdated Show resolved Hide resolved
@wmontwe wmontwe force-pushed the add-drawer-account-top-view branch from cd60d99 to 3e1c976 Compare September 12, 2024 15:03
@wmontwe wmontwe merged commit c05533a into thunderbird:main Sep 12, 2024
2 checks passed
@wmontwe wmontwe deleted the add-drawer-account-top-view branch September 12, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cketti cketti cketti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add account top view
2 participants
@wmontwe @cketti