Fix crashes in crypto provider selection dialogs #8081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cketti
changed the title
cketti
requested changes
Aug 26, 2024
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/OpenPgpAppSelectDialog.java
Outdated
Show resolved
Hide resolved
|
I have changed the code by your suggestion. |
cketti
requested changes
Aug 28, 2024
There was a problem hiding this comment.
- Please update the branch to remove unnecessary white space changes (see GitHub's diff view).
- Please use a more descriptive commit message, e.g. "Fix crashes in crypto provider selection dialogs".
- Please rewrite your branch to only contain one commit with the final change.
If you need help with any of that, please let us know and we can provide more detailed instructions.
|
I've deleted the unnecessary white space, but I don't know how to change the branch that only contain one commit with the final change. |
|
To get rid of merge commits and combine your individual commits into one, an interactive rebase can be used: I've fixed up this branch for you. Once the CI jobs have completed, this PR should be ready to be merged. |
cketti
approved these changes
Aug 30, 2024
|
Thank you for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8073