Split legacy - part 4 #8056
Merged
Split legacy - part 4 #8056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `MessagingControllerRegistry`
…n and move interface to `:legacy:mailstore` module
…ralSettingsManager`
… it to satisfy tailrec
…acy:ui:account` module
kewisch
approved these changes
Aug 7, 2024
| @@ -47,6 +41,7 @@ internal class DefaultMessageCountsProvider( | |||
| return MessageCounts(unreadCount, starredCount) | |||
| } | |||
|
|
|||
| @Suppress("TooGenericExceptionCaught") | |||
There was a problem hiding this comment.
Do we have a strategy to remove some of these suppressions in the future? Maybe some good first bugs to file?
There was a problem hiding this comment.
This specific warning is generated by our detekt code quality tool, which is desired to be reported in general. But there are cases where it is wrong or it's hard to provide the exact exception. Especially as our legacy code is designed to rely on try/catch constructs quite a lot. This is something we need to address when we touch that code base, but it's not easy to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last Part 4 of the legacy split, see previous pull-request: #8054
This is a step of the Material 3 drawer implementation to move the current drawer into a separate module #8032.
The goal of this is to allow use of necessary dependencies in the new drawer feature without running into circular dependency issues and establish a standalone feature.