Skip to content

Commit

Permalink
Bump version to 5.100
Browse files Browse the repository at this point in the history
  • Loading branch information
cketti committed Oct 8, 2014
1 parent 270160e commit 0f844fd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<manifest
package="com.fsck.k9"
xmlns:android="http://schemas.android.com/apk/res/android"
android:versionCode="21008"
android:versionName="4.905">
android:versionCode="23000"
android:versionName="5.100">

<uses-sdk
android:minSdkVersion="15"
Expand Down

6 comments on commit 0f844fd

@raoulbhatia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm4rk0
Copy link

@sm4rk0 sm4rk0 commented on 0f844fd Oct 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, where do these new permissions come from? I'm in the beta test group.
screenshot_2014-10-08-07-08-13

@sm4rk0
Copy link

@sm4rk0 sm4rk0 commented on 0f844fd Oct 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, found out myself:

Note: If your app uses the READ_CONTACTS permission and both your minSdkVersion and targetSdkVersion values are set to 15 or lower, the system implicitly grants your app this permission. If you don't need this permission, be sure your targetSdkVersion is 16 or higher.

http://developer.android.com/reference/android/Manifest.permission.html#READ_CALL_LOG

@cketti
Copy link
Member Author

@cketti cketti commented on 0f844fd Oct 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm4rk0: Thanks, I will look into that. Our targetSdkVersion is 17, so this shouldn't happen. It must have something to do with the fact that I used Gradle instead of ant to built this version.

@raoulbhatia: The Jenkins Android Emulator Plugin needs to be fixed to be able to download system images when using Android build tools v20+. That's why Job 23 wasn't built. I'm not sure when I find some time to properly fix this.

@raoulbhatia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cketti what other method would you recommended if I would like to use nightlies?

@cketti
Copy link
Member Author

@cketti cketti commented on 0f844fd Oct 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raoulbhatia My recommendation is to only use development/alpha versions. If you really want to use the latest repository snapshot I guess creating your own builds is the most reliable way to go.

Please sign in to comment.