Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch hint to label in create post page #1515

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 6, 2024

Pull Request Description

This is a super small PR which swaps hint text for label text on the create post page. I realized that you can't tell which field is which once you have entered your own text. And the terms we were using weren't really hints anyway, so I thought it made sense to switch all of these to labels.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit d6b93e9 into thunder-app:develop Aug 22, 2024
1 check passed
@micahmo micahmo deleted the feature/hint-to-label branch August 23, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants