Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: A dot prefix to active menu items #143

Closed
wants to merge 5 commits into from

Conversation

mrdotkg
Copy link

@mrdotkg mrdotkg commented Feb 22, 2021

@h-enk Talking about the Doks origin and plans in one of the discussions, I am guessing this would be in the Doks roadmaps.

Differentiate active menu item from rest, by prefixing a dot or circle symbol.

Screenshot 2021-02-22 at 10 15 32 PM

If not please ignore and reject. Thanks

Differentiate active menu item from rest by prefixing a dot or circle symbol
@h-enk
Copy link
Member

h-enk commented Feb 22, 2021

@mrdotkg, thanks — good idea! However I'm not quite sure yet about how to do the sidebar menu. I was also thinking about something like this:

2021-02-22_18-42-36

BTW, your deploy preview link: https://deploy-preview-143--doks.netlify.app/

Note, some checks failed on your PR — to keep things consistent, please run npm run lint:styles -- --fix to (probably) fix automatically.

@mrdotkg mrdotkg marked this pull request as ready for review February 23, 2021 05:57
@mrdotkg
Copy link
Author

mrdotkg commented Feb 23, 2021

@h-enk

This feature, your idea is Interesting and useful.

Thinking about something roughly like this

˃  EMAILS

⌄  FRUITS
   Apple
   • Banana
   Cherry
    
˃  GAMES

˃  HEROS

Preview link and these build errors are great help for contributing to the design. I used this website's workflow to create the pull request. Which is amazing by the way. But we get to know these errors only after the commit is done and build happened.

I had no idea at all that netlify provides automation for preview link -- pr#no

@mrdotkg mrdotkg changed the title A dot prefix to active menu items feat: A dot prefix to active menu items Feb 23, 2021
Comment on lines +88 to +90
.docs-link {
transition: all 0.3s;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to dig up an old PR, and sorry for the silly question. Why is there a transition here? Is this strictly necessary to add the dot at the start of the current menu item? Or does it affect something else not related to the dot?

@h-enk h-enk added the keep label Jan 14, 2022
@h-enk h-enk removed the keep label Feb 1, 2022
@h-enk
Copy link
Member

h-enk commented Feb 1, 2022

I'm sorry I didn't get back to you earlier. I appreciate your efforts — thanks for that!

I think the dot in front of an active page link is a little bit too much /distracts from the main content. Setting the font weight of an active page to 500 is — to my eye — sufficient and nicely in line with the design.

To speed things up /going forward w/ Doks v0.4.0, I will close your PR and merge #644

@h-enk h-enk closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants