-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/overhaul #999
Docs/overhaul #999
Conversation
…utorial notebooks
I now see that there are some typing issues, maybe some ignored rules were accidentally deleted from pyproject. Will look into it asap |
@opcode81 Have a look, if you want to. If you like this style, we could use a similar setup for sensai |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
- Coverage 88.09% 88.06% -0.04%
==========================================
Files 96 96
Lines 7527 7531 +4
==========================================
+ Hits 6631 6632 +1
- Misses 896 899 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fc31841
to
ff4b757
Compare
Is there an online link for preview? Also I can give you current rtd permission if you want |
Working on having it run in rtd - it's a painful journey. Almost done, I think, then I'll post the link for preview. My rtd profile name is MischaPanch, associtated to my GH account. Could you give me access to tianshou's official rtd project? |
Finally, the rtd build worked! Here |
I now see that the notebook outputs were not added, gonna fix that tomorrow |
love it, just added you to official rtd maintainer. there's an email need to click for accepting invitation |
Looks great! However, the API docs do not show up. Is that expected? |
63b8930
to
c50e74f
Compare
Completely done now, see https://tianshou-fork.readthedocs.io/en/latest/ Notebooks are executed and the api docs are also working fine. Had to dive deeper into rtd-docker-poetry stuff than I ever wanted to. @opcode81 helped in improving the task running, making them platform independent I force pushed and cleaned the history. I'd merge this without squashing after the checkmark, if that's ok. |
They do now |
Note that the main page for the api docs is empty, since the toc is displayed to the left and I didn't want to duplicate the pages for modules as well as init files. But if you go to the page of one of the modules, you get https://tianshou-fork.readthedocs.io/en/latest/03_api/data/batch.html Note the link to the source code, which is also uploaded to the docs and rendered there |
I improved the API docs landing page now, will be built in about 20 mins. Added a subtitle and displayed links to direct children, like for all subpackages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
Closes #916
This PR presents an overhaul of how the docs are built and presented
It was quite a piece of work, I hope you like the result :)